-
Notifications
You must be signed in to change notification settings - Fork 6.5k
docs: add user content for managed-by-url annotation #25055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
4129743 to
90848ac
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25055 +/- ##
==========================================
+ Coverage 62.24% 62.28% +0.04%
==========================================
Files 351 351
Lines 49231 49231
==========================================
+ Hits 30643 30665 +22
+ Misses 15663 15649 -14
+ Partials 2925 2917 -8 ☔ View full report in Codecov by Sentry. |
90848ac to
d8f6fd7
Compare
olivergondza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @aali309. The docs look good to me.
d8f6fd7 to
077fbc3
Compare
ishitasequeira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the document looks good. One suggestion on rephrasing the use case section.
fc991b5 to
f881402
Compare
ishitasequeira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Signed-off-by: Atif Ali <[email protected]>
Signed-off-by: Atif Ali <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]> Signed-off-by: Atif Ali <[email protected]>
Signed-off-by: Atif Ali <[email protected]>
f881402 to
c19b666
Compare
Created docs for: #23266